Fix Rotate on save as#611
Merged
erinharrington-12 merged 11 commits intomasterfrom Feb 19, 2026
Merged
Conversation
erinharrington-12
approved these changes
Feb 19, 2026
Contributor
erinharrington-12
left a comment
erinharrington-12
left a comment
There was a problem hiding this comment.
Pulled locally and approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509.
BabylonJS uses a left-handed coordinate system, but the demobot was modeled in a right-handed system. This meant that, with a rotation of (0, 0, 0), the demobot would face left from the main camera. As a quick fix, the
set originfunction insrc/simulator/babylonBindings/RobotBinding.tsadded a 90 degree offset. However, if the origin was set more than once in a single scene (such as by clicking the "Save As" button, among a few other things), the offset would be applied again. This fixes the issue by rotatingchassis.glbfacing the correct direction and updating all the child nodes accordingly.As part of this effort
Node.HingeJointnow requires the perpendicular axes to be defined explicitly, rather than hidden magic numbers.The left and right bumper switches on the demobot now match the left and right wheels (previously were opposite).
Since the iRobot Create is not part of Botball anymore, I simply removed it rather than update it's whole kinematic tree. This also fixes #518.