fix(tui): isolate background subagent session events - #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background subagents can stream tool cards and final-answer text into the foreground because the runtime broadcasts raw child-session events alongside parent-session tool mirrors.
Preserve session ownership during event normalization and reject events from other sessions at both TUI event entry points. Treat
inputSource: "subagent"turns as task-scoped without starting a parent result handoff, so foreground input handling stays independent of child execution. Parent TaskOutput results and background completion notifications remain visible.Regression coverage injects two child sessions' text, Bash activity, protocol parts, and nested-task notifications, then checks both the normal and expanded foreground transcript while preserving a parent TaskOutput result.
Validation:
bun test --dots: 612 passed, 0 failedbun run typecheckbun run buildbun scripts/check-runtime.tsbun run check:tuibun scripts/check-package.tsgit diff --checkFixes #129