Repository navigation
Fiddle: fall back to the bundled icon set versions - #260
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KibaIcon's runtime fallback now fetches the same icon set versions the vite plugin bundles, so an icon looks the same either way:
ionicons/v8(was v5),material-icons/v2(from@material-design-icons/svg, was v1) andremix-icons/v4(was v2). bootstrap-icons v1 and feather v4 keep their paths.Merge only after
node scripts/upload-icon-sets.mjsfrom kibalabs/assets-proxy#10 has uploaded the new folders, or ion/mui/remix fallbacks will 404. Old ui-react versions keep using the old folders, which stay.