Repository navigation
Feature: merge ui-react-toast and ui-react-dropzone into @kibalabs/ui-react - #258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step of folding the JS libraries into two packages (build-js #137, core-js #55 done; yieldseeker next).
@kibalabs/ui-react/toast= all of@kibalabs/ui-react-toast,@kibalabs/ui-react/dropzone= all of@kibalabs/ui-react-dropzone, withreact-hot-toast/react-dropzoneas optional peer dependencies.styles.css|scssas before, plustoast/styles.css|scssanddropzone/styles.css|scss(only their own rules, used on top of the main styles).@kibalabs/core/reactinstead of@kibalabs/core-react;react-routerbecomes a required peer (the main entry uses it through core/react).Checks: lint, type-check, build, build-docs.
dist/index.cssis byte-identical to the published 0.12.1-next.12, and the toast and dropzone css to the old packages'. Main entry JS/types are the same apart from the import rename. Tested in the yieldseeker prototype (local stack, headless Chrome vs main): toasts, pages and styles unchanged.