Fix pollbot invalid inputs - #355
Open
michalz-zoom wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens pollbot’s vote handling by rejecting malformed/invalid vote payloads and out-of-range choices before writing to the database or updating poll results.
Changes:
- Update
NewVoteFromEncodedto return(Vote, error)and properly handle decode/msgpack failures plus missing poll IDs. - In the HTTP vote handler, reject invalid vote payloads and enforce
Choicebounds based on the poll’snumChoicesbefore casting the vote.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pollbot/pollbot/vote.go | Adds error-returning decode path and validates required fields when decoding votes. |
| pollbot/pollbot/http.go | Validates decoded vote payloads and enforces choice range before persisting and updating tallies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return | ||
| } | ||
| if vote.Choice < 1 || vote.Choice > numChoices { | ||
| h.Debug("vote choice %d out of range for poll %s", vote.Choice, vote.ID) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.