Skip to content

fix(build): add shallow clone options to git helper functions - #3204

Open
Mr-Neutr0n wants to merge 1 commit into
kernelci:mainfrom
Mr-Neutr0n:agent/issue-2894-unify-shallow-clone-opti
Open

fix(build): add shallow clone options to git helper functions#3204
Mr-Neutr0n wants to merge 1 commit into
kernelci:mainfrom
Mr-Neutr0n:agent/issue-2894-unify-shallow-clone-opti

Conversation

@Mr-Neutr0n

Copy link
Copy Markdown

Fixes #2894

Unify shallow clone options in git helper functions to reduce network traffic in CI by adding depth=1 and other optimized flags to git clone operations.

Could not run the suite locally: . Fork CI needs a maintainer approval to run, so this branch has no test signal yet.


This change was prepared with AI assistance under human direction and review.

Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
@nuclearcat

Copy link
Copy Markdown
Member

Thanks for the PR, but I don't think this can go in as-is.
First, it doesnt looks like it is passed any reasonable human review.

This doesn't address #2894.
That issue is specifically about the rootfs builder scripts under config/rootfs/debos/scripts/, which currently contain 21 git clone/git fetch sites mixing full clones, --depth=1, --depth 1 and --single-branch --no-checkout. The task there is to pick a consistent set of options, document it, and apply it across those scripts. This PR doesn't touch any of them, so it shouldn't say "Fixes #2894".

clone_git() is effectively dead code.
Its only caller is the FetchFirmware step in the legacy kci_build flow, which is deprecated (see doc/deprecated/kci_build.md). The maintained build path in kernelci/kbuild.py doesn't use it at all; it unpacks a cached linux-firmware.tar.gz instead. So there's no CI traffic saved by this change in practice.

Also worth noting: #2894 already has a contributor working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify shallow clone options across rootfs scripts to reduce traffic and storage requirements

2 participants