Skip to content

Test browser pool data source against Kernel - #80

Open
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-chrome-policyfrom
hypeship/browser-pool-data-source-acceptance
Open

Test browser pool data source against Kernel#80
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-chrome-policyfrom
hypeship/browser-pool-data-source-acceptance

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add opt-in live API coverage for the kernel_browser_pool data source
  • create one uniquely named durable pool and read it by canonical ID and exact name
  • verify normalized durable configuration and null or empty optional references
  • prove a no-drift follow-up plan
  • verify normal Terraform destroy through a coded not_found API response
  • keep SDK deletion as an early-failure cleanup fallback
  • add the package to the workflow and documented seven-package acceptance matrix

Scope

Acceptance coverage and release-gate documentation only. This PR does not change provider behavior, schemas, SDK contracts, or runtime/session operations.

The fixture uses KERNEL_ALT_PROJECT_ID when available and otherwise uses KERNEL_PROJECT_ID. At least one must be set. Destruction remains non-forceful.

Tests run

  • go test -short -timeout=2m ./...
  • go vet ./...
  • gofmt -l cmd internal
  • terraform fmt -check -recursive examples
  • bash scripts/check-docs.sh
  • bash scripts/check-markdown-links.sh
  • git diff --check

Live acceptance

Passed on commit 3259a54 in workflow run 30660137930.

All seven jobs passed. The new browser-pool data-source job completed in 34 seconds and covered ID lookup, exact-name lookup, explicit project scope, normalized durable state, null references, no drift, non-force destroy, and coded not_found verification.

Intentionally unsupported

  • runtime counters or leased/session state
  • acquire, release, flush, force recovery, screenshots, logs, or live view
  • browser-pool writes through the data source

@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai and removed request for Sayan- and tnsardesai July 11, 2026 12:10
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from af40ac2 to a9c7241 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from f3fde8a to e903631 Compare July 13, 2026 13:35
Comment thread internal/datasources/browserpool/datasource_acc_test.go
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from e903631 to f837de4 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from a9c7241 to dfdb402 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from f837de4 to d6ec19c Compare July 13, 2026 15:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d6ec19c. Configure here.

Comment thread internal/datasources/browserpool/datasource_acc_test.go
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from 20fff2e to f470d3d Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from d6ec19c to 26bcbc5 Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from f470d3d to 2905808 Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from 26bcbc5 to 018faaa Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from 2905808 to c9a8321 Compare July 21, 2026 18:10
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch 3 times, most recently from 7dc356a to f868d78 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-chrome-policy branch from a0a227d to 95039fa Compare July 31, 2026 19:30
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from f868d78 to 5ada561 Compare July 31, 2026 19:35
Add opt-in acceptance coverage for ID and exact-name lookup, durable state flattening, no-drift planning, project overrides, and cleanup. Run it only from the manual acceptance matrix.
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-acceptance branch from 5ada561 to 3259a54 Compare July 31, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant