Expose browser pool warmup configuration - #77
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 11:16
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 13, 2026 13:35
a37d0a1 to
f334e30
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
2 times, most recently
from
July 13, 2026 14:32
a2270fa to
a60a6b4
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 13, 2026 15:39
2ef7bb9 to
c8472f3
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 13, 2026 15:39
a60a6b4 to
9699f7f
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 20, 2026 19:38
9699f7f to
de2d434
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 20, 2026 19:38
c8472f3 to
eb178f6
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
2 times, most recently
from
July 21, 2026 18:10
cd0ea6e to
01473c5
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
2 times, most recently
from
July 21, 2026 19:51
20349be to
eff8bf1
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 21, 2026 19:51
01473c5 to
0ac42d2
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 21, 2026 20:15
eff8bf1 to
67489e8
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 21, 2026 20:15
0ac42d2 to
1bcac42
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 31, 2026 19:24
67489e8 to
c1a1090
Compare
Read start URL, timeout, and fill rate into durable data-source state. Validate SDK response types and ranges while preserving omitted values and known zero.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-warmup-config
branch
from
July 31, 2026 19:26
1bcac42 to
9396869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_url,timeout_seconds, andfill_rate_per_minuteScope
Additive v1 durable read-only state only. Viewport, Chrome policy, runtime state, and live acceptance remain separate.
Tests
Ran focused tests repeatedly, race tests, full short suite, vet, gofmt, module verification/tidy diff, Terraform example fmt, docs drift, and diff checks.
Coverage includes Framework known zero, all omitted fields as typed null, inclusive timeout bounds, explicit null, wrong types, empty URL, and out-of-range values.
Acceptance not run; live response/project-scope proof remains deferred to opt-in acceptance tests.
Note
Low Risk
Additive read-only data source attributes and validation on API response flattening; no resource writes or auth changes.
Overview
The
kernel_browser_pooldata source now surfaces three additional computed warmup fields from durable pool config:start_url,timeout_seconds, andfill_rate_per_minute, with matching Registry docs.Flattening follows the same optional-field pattern as existing launch settings: omitted SDK JSON becomes Terraform null; explicit null, wrong types, or invalid values raise diagnostics instead of silently coercing state.
timeout_secondsmust be between 10 and 259200;fill_rate_per_minutemust be ≥ 0, including preserving a known 0 in Framework state. Unit tests cover schema attributes, read wiring, boundary values, and rejection cases.Reviewed by Cursor Bugbot for commit 9396869. Bugbot is set up for automated code reviews on this repo. Configure here.