Skip to content

Expose browser pool warmup configuration - #77

Open
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-launch-configfrom
hypeship/browser-pool-data-source-warmup-config
Open

Expose browser pool warmup configuration#77
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-launch-configfrom
hypeship/browser-pool-data-source-warmup-config

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose computed start_url, timeout_seconds, and fill_rate_per_minute
  • distinguish omission from explicit null/malformed SDK values
  • enforce timeout 10 through 259200 and non-negative fill rate
  • preserve known zero through Terraform Framework state
  • update generated Registry docs

Scope

Additive v1 durable read-only state only. Viewport, Chrome policy, runtime state, and live acceptance remain separate.

Tests

Ran focused tests repeatedly, race tests, full short suite, vet, gofmt, module verification/tidy diff, Terraform example fmt, docs drift, and diff checks.

Coverage includes Framework known zero, all omitted fields as typed null, inclusive timeout bounds, explicit null, wrong types, empty URL, and out-of-range values.

Acceptance not run; live response/project-scope proof remains deferred to opt-in acceptance tests.


Note

Low Risk
Additive read-only data source attributes and validation on API response flattening; no resource writes or auth changes.

Overview
The kernel_browser_pool data source now surfaces three additional computed warmup fields from durable pool config: start_url, timeout_seconds, and fill_rate_per_minute, with matching Registry docs.

Flattening follows the same optional-field pattern as existing launch settings: omitted SDK JSON becomes Terraform null; explicit null, wrong types, or invalid values raise diagnostics instead of silently coercing state. timeout_seconds must be between 10 and 259200; fill_rate_per_minute must be ≥ 0, including preserving a known 0 in Framework state. Unit tests cover schema attributes, read wiring, boundary values, and rejection cases.

Reviewed by Cursor Bugbot for commit 9396869. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai and removed request for Sayan- and tnsardesai July 11, 2026 11:16
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from a37d0a1 to f334e30 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch 2 times, most recently from a2270fa to a60a6b4 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from 2ef7bb9 to c8472f3 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch from a60a6b4 to 9699f7f Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch from 9699f7f to de2d434 Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from c8472f3 to eb178f6 Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch 2 times, most recently from cd0ea6e to 01473c5 Compare July 21, 2026 18:10
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch 2 times, most recently from 20349be to eff8bf1 Compare July 21, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch from 01473c5 to 0ac42d2 Compare July 21, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from eff8bf1 to 67489e8 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch from 0ac42d2 to 1bcac42 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from 67489e8 to c1a1090 Compare July 31, 2026 19:24
Read start URL, timeout, and fill rate into durable data-source state. Validate SDK response types and ranges while preserving omitted values and known zero.
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-warmup-config branch from 1bcac42 to 9396869 Compare July 31, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant