Skip to content

Expose browser pool launch configuration - #76

Open
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-resolved-refsfrom
hypeship/browser-pool-data-source-launch-config
Open

Expose browser pool launch configuration#76
IlyaasK wants to merge 1 commit into
hypeship/browser-pool-data-source-resolved-refsfrom
hypeship/browser-pool-data-source-launch-config

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • expose computed proxy_id, headless, kiosk_mode, and stealth on kernel_browser_pool
  • preserve known false values through Terraform Framework state serialization
  • return typed null only for omitted optional SDK fields
  • reject explicit JSON null and malformed present values
  • update generated Registry docs

Why this is v1 work

This is an additive durable read-only surface. It does not change v0 resources or introduce runtime/session operations. URL/rate settings, viewport, and Chrome policy remain separate PRs.

State semantics

SDK omission means the optional field is absent and maps to Terraform null. Explicit null is invalid because these SDK fields are non-nullable. Present booleans retain both true and false as known values.

Tests run

  • go test -count=20 ./internal/datasources/browserpool
  • go test -race ./internal/datasources/browserpool ./internal/provider
  • go test -short -timeout=2m ./...
  • go vet ./...
  • gofmt, module verify/tidy diff, Terraform example fmt, docs drift, and diff checks

Tests cover omitted values, valid proxy/booleans, known false through Read -> State.Set -> State.Get, explicit null for all four fields, wrong types, and empty proxy IDs.

Acceptance status

Not run. Live response and project-scoping proof remains deferred to the opt-in acceptance slice.


Note

Low Risk
Additive computed-only data source attributes with validation; no resources or write paths changed.

Overview
Adds read-only proxy_id, headless, kiosk_mode, and stealth to the kernel_browser_pool data source so Terraform can surface durable launch settings from browser_pool_config.

Flattening maps SDK omitted optional fields to Terraform null, keeps known false (and other present values) in state, and errors on explicit JSON null, wrong types, or invalid proxy_id (including empty string). Registry docs for the data source are updated accordingly.

Tests cover schema attributes, full read/state round-trip, happy-path flattening, and invalid API payloads for all four fields.

Reviewed by Cursor Bugbot for commit c1a1090. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai and removed request for Sayan- and tnsardesai July 11, 2026 11:03
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from e34989f to 867f435 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from a37d0a1 to f334e30 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from 867f435 to c957fa0 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch 2 times, most recently from 2ef7bb9 to c8472f3 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from c8472f3 to eb178f6 Compare July 20, 2026 19:38
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from 9237b28 to baf2210 Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from eb178f6 to a33501f Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from baf2210 to b19872f Compare July 21, 2026 18:10
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch 2 times, most recently from 20349be to eff8bf1 Compare July 21, 2026 19:51
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from 735c9f6 to 6b2c9bc Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from eff8bf1 to 67489e8 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-resolved-refs branch from 6b2c9bc to 7637450 Compare July 31, 2026 19:21
Read proxy and launch-mode fields into durable data-source state. Reject explicit null or malformed SDK values and preserve known false booleans through Terraform serialization.
@IlyaasK
IlyaasK force-pushed the hypeship/browser-pool-data-source-launch-config branch from 67489e8 to c1a1090 Compare July 31, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant