Expose browser pool launch configuration - #76
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 11:03
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 13, 2026 13:35
e34989f to
867f435
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 13, 2026 13:35
a37d0a1 to
f334e30
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 13, 2026 14:32
867f435 to
c957fa0
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
2 times, most recently
from
July 13, 2026 15:39
2ef7bb9 to
c8472f3
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 20, 2026 19:38
c8472f3 to
eb178f6
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 21, 2026 14:46
9237b28 to
baf2210
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 21, 2026 14:46
eb178f6 to
a33501f
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 21, 2026 18:10
baf2210 to
b19872f
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
2 times, most recently
from
July 21, 2026 19:51
20349be to
eff8bf1
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 21, 2026 20:15
735c9f6 to
6b2c9bc
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 21, 2026 20:15
eff8bf1 to
67489e8
Compare
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-resolved-refs
branch
from
July 31, 2026 19:21
6b2c9bc to
7637450
Compare
Read proxy and launch-mode fields into durable data-source state. Reject explicit null or malformed SDK values and preserve known false booleans through Terraform serialization.
IlyaasK
force-pushed
the
hypeship/browser-pool-data-source-launch-config
branch
from
July 31, 2026 19:24
67489e8 to
c1a1090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy_id,headless,kiosk_mode, andstealthonkernel_browser_poolfalsevalues through Terraform Framework state serializationWhy this is v1 work
This is an additive durable read-only surface. It does not change v0 resources or introduce runtime/session operations. URL/rate settings, viewport, and Chrome policy remain separate PRs.
State semantics
SDK omission means the optional field is absent and maps to Terraform null. Explicit null is invalid because these SDK fields are non-nullable. Present booleans retain both true and false as known values.
Tests run
go test -count=20 ./internal/datasources/browserpoolgo test -race ./internal/datasources/browserpool ./internal/providergo test -short -timeout=2m ./...go vet ./...Tests cover omitted values, valid proxy/booleans, known false through
Read -> State.Set -> State.Get, explicit null for all four fields, wrong types, and empty proxy IDs.Acceptance status
Not run. Live response and project-scoping proof remains deferred to the opt-in acceptance slice.
Note
Low Risk
Additive computed-only data source attributes with validation; no resources or write paths changed.
Overview
Adds read-only
proxy_id,headless,kiosk_mode, andstealthto thekernel_browser_pooldata source so Terraform can surface durable launch settings frombrowser_pool_config.Flattening maps SDK omitted optional fields to Terraform null, keeps known
false(and other present values) in state, and errors on explicit JSON null, wrong types, or invalidproxy_id(including empty string). Registry docs for the data source are updated accordingly.Tests cover schema attributes, full read/state round-trip, happy-path flattening, and invalid API payloads for all four fields.
Reviewed by Cursor Bugbot for commit c1a1090. Bugbot is set up for automated code reviews on this repo. Configure here.