Wire extension metadata into Terraform Read - #66
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
IlyaasK
requested review from
Sayan- and
tnsardesai
and removed request for
Sayan- and
tnsardesai
July 11, 2026 06:40
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 13, 2026 13:34
0b96a2c to
d13b0cb
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
3 times, most recently
from
July 13, 2026 15:39
ca7698d to
768706f
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 13, 2026 15:39
0729a85 to
27974c1
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 20, 2026 19:38
27974c1 to
425ae2f
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 20, 2026 19:38
768706f to
1cbbde5
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 21, 2026 14:46
425ae2f to
b14832d
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 14:46
1cbbde5 to
bb43138
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 21, 2026 18:10
b14832d to
85ea5af
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 18:10
bb43138 to
55234ad
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-core
branch
from
July 21, 2026 19:51
85ea5af to
ecdfa1a
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 19:51
55234ad to
83939e3
Compare
IlyaasK
force-pushed
the
hypeship/extension-read-framework
branch
from
July 21, 2026 20:15
83939e3 to
d503c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is v1 work
This is the narrow Framework state-transition boundary over the already-reviewed metadata Read core. It keeps registration and incomplete Delete/Import behavior out of the PR.
Intentionally unsupported
kernel_extensionresourceVerification
gofmt -l cmd internalgo test -count=20 ./internal/resources/extensiongo test -race -count=1 ./internal/resources/extensiongo test -count=1 -short -timeout=2m ./...go vet ./...go mod tidy -diffterraform fmt -check -recursive examplesbash scripts/check-docs.shbash scripts/check-examples.shbash scripts/check-markdown-links.shgit diff --checkAll commands passed locally. Tests are fake-client based, deterministic, and require no network or container.
Acceptance status
The resource remains unregistered and lacks Delete/Import, so live acceptance testing is not applicable to this adapter-only slice.
Remaining risk
The complete resource must preserve these state transitions when Create, Read, Delete, Import, Configure, and provider registration are assembled.
Note
Low Risk
Adapter-only slice with no provider registration; behavior is narrow state transitions over an already-reviewed read core and is fully covered by unit tests.
Overview
Adds a Terraform Plugin Framework Read handler (
readExtensionResource) that bridgesresource.ReadRequest/ReadResponseto the existingreadExtensionmetadata core.On read it decodes prior state first, then on success writes refreshed state or removes the resource when the core reports a coded
not_found. Diagnostics leave response state unchanged (no partial writes).New fake-client tests cover successful refresh, not-found removal, error preservation, and malformed state without calling the API.
Reviewed by Cursor Bugbot for commit d503c89. Bugbot is set up for automated code reviews on this repo. Configure here.