Add browser pool profile refresh policy - #111
Open
IlyaasK wants to merge 1 commit into
Open
Conversation
Expose Kernel's durable refresh_on_profile_update setting through the browser pool resource. Preserve API defaults when omitted, retain explicit false values across profile changes, validate the profile dependency, and cover create/update/read behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refresh_on_profile_updatebrowser-pool policy as an optional/computed Terraform attributeprofile_idchanges sofalseis not replaced by the API defaulttruerequiresprofile_idWhy
Kernel's API and Go SDK already support this durable browser-pool setting. Terraform should manage the same durable desired state as the CLI while keeping runtime pool operations outside the provider.
Intentionally unsupported
This does not add browser acquire/release/flush operations, leased-browser state, force deletion, profile mutation, or any other runtime/session behavior.
Verification
gofmt -l cmd internalgo test -short -timeout=2m ./...go vet ./...terraform fmt -check -recursive examplesbash scripts/check-docs.shbash scripts/check-markdown-links.shThe guarded live acceptance matrix passed on the top stacked branch: https://github.com/kernel/terraform-provider-kernel/actions/runs/30667323827. All seven jobs passed, including browser-pool create/read/update/import/delete and browser-pool data-source lookup.