Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
approved these changes
Sep 18, 2026
masnwilliams
left a comment
Collaborator
There was a problem hiding this comment.
Verified the protected-resource metadata and unauthenticated MCP challenge against the preview deployment; both advertise the expected path-specific HTTPS resource and metadata URL. The test suite, typecheck, formatting for changed files, and CI pass.
Non-blocking cleanup: now that /mcp is public at the Clerk middleware layer, the later MCP-specific middleware branch no longer governs the canonical endpoint and can be removed separately. Keep the documented rollout sequencing in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the protected-resource identifier from the origin-only URL to
https://mcp.onkernel.com/mcp. RFC 9728 §3.3 requires it to match the resource used to derive/.well-known/oauth-protected-resource/mcp; strict discovery clients reject the previous value.no-store, and legacy OAuth routes and credential storage./mcpreach the existing bearer-token validation instead of Clerk page protection; other protected pages remain protected.Rollout gate — do not merge/deploy yet
Deploy companion client issuer/registration/resource pinning and explicit reconnect handling before this correction. Accepting corrected discovery must not silently move retained credentials to a different issuer during callback or refresh. Existing registrations do not automatically migrate.
Preserve old in-flight resource bindings exactly: the Go broker accepts
/mcp, but token exchange compares against the resource stored in the authorization transaction. The retained TypeScript token route continues forwarding origin-only,/mcp, or omitted resources without rewriting them. Cached-client recovery and live token/refresh compatibility remain separately authorized rollout checks.Validation
Using Bun 1.3.3 (matching CI):
bun test: 656 passed, 0 failed across 59 files.bunx tsc --noEmit --incremental false: passed.bun run check:managed-auth-app: passed.git diff --check: passed.No live registration, authorization, token, or refresh probes were run. Metadata route tests mock Clerk discovery; token tests inject mock dependencies. No full Next.js build or local Redis recording regeneration was run. No production, DNS, or credential changes were made.