Support credential field labels - #205
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 852316b. Configure here.
rgarcia
left a comment
There was a problem hiding this comment.
reviewed — overall looks good. one documentation gap worth addressing:
Suggestion
src/lib/mcp/tools/vault-credentials.ts:33-37— consider documenting the runtime label constraints in MCP discovery: trimmed, ≤128 UTF-8 bytes, and no control/format characters. Otherwise invalid labels receive only the generic schema error.
|
addressed the label-discovery suggestion in c04f44a: the MCP schema now lists the trim, UTF-8 byte limit, and disallowed-character constraints, with a discovery regression test. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|

summary
rollout
kernel/kernel#4214 is deployed, and this PR now uses the published
@onkernel/sdk@^0.110.0release.testing
bun testbunx tsc --noEmitbun run check:managed-auth-appgit diff --checkNote
Medium Risk
Changes the vault credential MCP contract and validation for user-facing collection forms; stable names still drive fill/update, but misconfigured clients could see new rejections or rely on labels incorrectly.
Overview
Adds optional human-readable labels on credential field definitions in
manage_vault_credentials, alongside the existing stablenamekeys used for updates and browser fill.Labels are validated in MCP input (non-empty, trimmed, ≤128 UTF-8 bytes, no control/formatting/line-separator characters). Invalid labels are covered by new create-path tests; tool discovery and returned credential metadata now expose
label, with MCP guidance updated to clarify that labels are display-only.@onkernel/sdkis bumped from0.109.0to0.110.0(lockfile included) to align with backend support for field labels.Reviewed by Cursor Bugbot for commit 8b3520e. Bugbot is set up for automated code reviews on this repo. Configure here.