Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions src/lib/mcp/responses.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { APIError } from "@onkernel/sdk";

type PaginatedPage<T> = {
getPaginatedItems(): T[];
has_more?: boolean | null;
Expand Down Expand Up @@ -64,12 +66,38 @@ function errorMessage(error: unknown) {
return error instanceof Error ? error.message : String(error);
}

export function toolErrorResponse(
// Named after what the API said, so a stale session id (404) is distinguishable from an
// org hitting its limits (429) or a fault on our side (5xx). Status codes only; the
// message stays out.
class ToolCallError extends Error {
constructor(name: string, message: string) {
super(message);
this.name = name;
}
}

function errorName(error: unknown) {
if (error instanceof APIError && typeof error.status === "number") {
return `KernelApiError${error.status}`;
}
return error instanceof Error ? error.constructor.name : "Error";
}

/**
* Fails a tool call that a Kernel API request rejected.
*
* Throws rather than returning an isError result: analytics reads the error category
* from a thrown error's name, while a returned result only ever coerces to a generic
* "Error". The MCP SDK turns the throw back into the same isError text result the client
* saw before, so agents see no difference.
*/
export function throwToolError(
toolName: string,
action: string,
error: unknown,
) {
return errorResponse(
): never {
throw new ToolCallError(
errorName(error),
`Error in ${toolName} (${action}): ${errorMessage(error)}`,
);
}
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/api-keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -107,7 +107,7 @@ export function registerAPIKeyCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_api_keys", params.action, error);
throwToolError("manage_api_keys", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/apps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -206,7 +206,7 @@ export function registerAppCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_apps", params.action, error);
throwToolError("manage_apps", params.action, error);
}
},
);
Expand Down
8 changes: 2 additions & 6 deletions src/lib/mcp/tools/auth-connections.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -255,11 +255,7 @@ export function registerAuthConnectionTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse(
"manage_auth_connections",
params.action,
error,
);
throwToolError("manage_auth_connections", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/browser-curl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { createKernelClient, type KernelClient } from "@/lib/mcp/kernel-client";
import {
errorResponse,
jsonResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";

type BrowserCurlParams = Parameters<KernelClient["browsers"]["curl"]>[1];
Expand Down Expand Up @@ -74,7 +74,7 @@ export function registerBrowserCurlTool(server: McpServer) {
const response = await client.browsers.curl(session_id, curlParams);
return jsonResponse(response);
} catch (error) {
return toolErrorResponse("browser_curl", "request", error);
throwToolError("browser_curl", "request", error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/browser-pools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
errorResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -474,7 +474,7 @@ export function registerBrowserPoolCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_browser_pools", params.action, error);
throwToolError("manage_browser_pools", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/browsers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";
import {
Expand Down Expand Up @@ -695,7 +695,7 @@ export function registerBrowserCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_browsers", params.action, error);
throwToolError("manage_browsers", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/computer-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
errorResponse,
jsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";

type ComputerClient = KernelClient["browsers"]["computer"];
Expand Down Expand Up @@ -353,7 +353,7 @@ export function registerComputerActionTool(server: McpServer) {
`Executed ${executedActionCount} action(s) successfully`,
);
} catch (error) {
return toolErrorResponse("computer_action", "actions", error);
throwToolError("computer_action", "actions", error);
}
},
);
Expand Down
8 changes: 2 additions & 6 deletions src/lib/mcp/tools/credential-providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -164,11 +164,7 @@ export function registerCredentialProviderTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse(
"manage_credential_providers",
params.action,
error,
);
throwToolError("manage_credential_providers", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/credentials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -152,7 +152,7 @@ export function registerCredentialTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_credentials", params.action, error);
throwToolError("manage_credentials", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
errorResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -53,7 +53,7 @@ export function registerExtensionTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_extensions", params.action, error);
throwToolError("manage_extensions", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/profiles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -214,7 +214,7 @@ export function registerProfileCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_profiles", params.action, error);
throwToolError("manage_profiles", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/projects.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -175,7 +175,7 @@ export function registerProjectCapabilities(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_projects", params.action, error);
throwToolError("manage_projects", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/proxies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
jsonResponse,
paginatedJsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";
import { paginationParams } from "@/lib/mcp/schemas";

Expand Down Expand Up @@ -169,7 +169,7 @@ export function registerProxyTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_proxies", params.action, error);
throwToolError("manage_proxies", params.action, error);
}
},
);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/mcp/tools/replays.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
itemsJsonResponse,
jsonResponse,
textResponse,
toolErrorResponse,
throwToolError,
} from "@/lib/mcp/responses";

export function registerReplayTools(server: McpServer) {
Expand Down Expand Up @@ -90,7 +90,7 @@ export function registerReplayTools(server: McpServer) {
}
}
} catch (error) {
return toolErrorResponse("manage_replays", params.action, error);
throwToolError("manage_replays", params.action, error);
}
},
);
Expand Down
Loading