Skip to content

Pin qboot firmware for QEMU microvm guests #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sjmiller609 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Draft

Pin qboot firmware for QEMU microvm guests #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/hypervisor/qemu/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ func buildArgs(cfg hypervisor.VMConfig, machine MachineType) []string {
// Do not allow a host qemu.conf to add devices outside microvm's
// documented eight virtio-mmio-device limit.
args = append(args, "-no-user-config")
// Pin upstream's default microvm firmware. Some distros point
// bios-microvm.bin at SeaBIOS instead, whose ACPI tables omit the
// IOAPICs and crash the guest kernel during early boot.
args = append(args, "-bios", "qboot.rom")
}

// CPU configuration
Expand Down
1 change: 1 addition & 0 deletions lib/hypervisor/qemu/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ func TestBuildArgs_MicroVM(t *testing.T) {
args := buildArgs(cfg, MachineTypeMicroVM)
assert.Contains(t, args, "microvm,accel=kvm")
assert.Contains(t, args, "-no-user-config")
assert.Contains(t, args, "qboot.rom")
assert.Contains(t, args, "virtio-blk-device,drive=drive0")
assert.Contains(t, args, "virtio-net-device,netdev=net0,mac=02:00:00:ab:cd:ef")
assert.Contains(t, args, "vhost-vsock-device,guest-cid=123")
Expand Down
Loading