Skip to content

Pin Redis image for entrypoint env tests#303

Merged
sjmiller609 merged 1 commit into
mainfrom
codex/pin-bitnami-redis-ci
Jul 8, 2026
Merged

Pin Redis image for entrypoint env tests#303
sjmiller609 merged 1 commit into
mainfrom
codex/pin-bitnami-redis-ci

Conversation

@sjmiller609

@sjmiller609 sjmiller609 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace mutable bitnami/redis:latest in entrypoint env tests with the legacy Bitnami Redis 7.2.5 Debian image
  • share the pinned image ref across Cloud Hypervisor and QEMU variants

Why

Main was failing on deft-kernel-dev with misleading vsock errors in TestEntrypointEnvVars and TestQEMUEntrypointEnvVars. The VM logs showed the guest agent did become ready, but the current bitnami/redis:latest image exited immediately with:

Fatal error, can't open config file '/opt/bitnami/redis/etc/redis.conf': Permission denied

That powered off the VM, so later guest exec attempts reported missing/no-device vsock.

Validation

  • On deft-kernel-dev, after mirroring docker.io/bitnamilegacy/redis:7.2.5-debian-12-r0 into the local CI registry:
    go test -tags containers_image_openpgp -run "Test(EntrypointEnvVars|QEMUEntrypointEnvVars)$" -count=1 -v -timeout=8m ./lib/instances
  • Both tests passed in 6.826s.

Note

Low Risk
Test and CI prewarm image list only; no production runtime or auth logic changes.

Overview
Replaces the floating docker.io/bitnami/redis:latest reference with a pinned docker.io/bitnamilegacy/redis:7.2.5-debian-12-r0 so entrypoint env integration tests stop failing when upstream latest breaks in the guest (e.g. Redis exiting on config permission errors and surfacing as vsock/exec failures).

Adds a shared redisEntrypointEnvImage constant in manager_test.go and uses it in TestEntrypointEnvVars and TestQEMUEntrypointEnvVars for both image pull and instance create. cmd/test-prewarm mirrors the same tag in defaultImages, with a comment to keep it aligned with the test constant.

Reviewed by Cursor Bugbot for commit b1c911c. Bugbot is set up for automated code reviews on this repo. Configure here.

@sjmiller609 sjmiller609 marked this pull request as ready for review July 8, 2026 18:19
@sjmiller609 sjmiller609 requested review from IlyaasK and yummybomb July 8, 2026 18:19

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 519b5fe. Configure here.

Comment thread lib/instances/manager_test.go
@sjmiller609 sjmiller609 force-pushed the codex/pin-bitnami-redis-ci branch from 519b5fe to b1c911c Compare July 8, 2026 18:32
@sjmiller609 sjmiller609 marked this pull request as draft July 8, 2026 18:33
@IlyaasK IlyaasK marked this pull request as ready for review July 8, 2026 18:34

@IlyaasK IlyaasK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that redis being latest is not mission critical, so lgtm

@sjmiller609 sjmiller609 merged commit f93e17a into main Jul 8, 2026
11 checks passed
@sjmiller609 sjmiller609 deleted the codex/pin-bitnami-redis-ci branch July 8, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants