Pin Redis image for entrypoint env tests#303
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 519b5fe. Configure here.
519b5fe to
b1c911c
Compare
IlyaasK
approved these changes
Jul 8, 2026
IlyaasK
left a comment
There was a problem hiding this comment.
seems that redis being latest is not mission critical, so lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
Main was failing on deft-kernel-dev with misleading vsock errors in TestEntrypointEnvVars and TestQEMUEntrypointEnvVars. The VM logs showed the guest agent did become ready, but the current bitnami/redis:latest image exited immediately with:
Fatal error, can't open config file '/opt/bitnami/redis/etc/redis.conf': Permission deniedThat powered off the VM, so later guest exec attempts reported missing/no-device vsock.
Validation
go test -tags containers_image_openpgp -run "Test(EntrypointEnvVars|QEMUEntrypointEnvVars)$" -count=1 -v -timeout=8m ./lib/instancesNote
Low Risk
Test and CI prewarm image list only; no production runtime or auth logic changes.
Overview
Replaces the floating
docker.io/bitnami/redis:latestreference with a pinneddocker.io/bitnamilegacy/redis:7.2.5-debian-12-r0so entrypoint env integration tests stop failing when upstreamlatestbreaks in the guest (e.g. Redis exiting on config permission errors and surfacing as vsock/exec failures).Adds a shared
redisEntrypointEnvImageconstant inmanager_test.goand uses it inTestEntrypointEnvVarsandTestQEMUEntrypointEnvVarsfor both image pull and instance create.cmd/test-prewarmmirrors the same tag indefaultImages, with a comment to keep it aligned with the test constant.Reviewed by Cursor Bugbot for commit b1c911c. Bugbot is set up for automated code reviews on this repo. Configure here.