Skip to content

Support credential field labels - #263

Merged
masnwilliams merged 2 commits into
mainfrom
hypeship/credential-field-labels
Sep 18, 2026
Merged

masnwilliams merged 2 commits into
mainfrom
hypeship/credential-field-labels

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

summary

  • accept optional credential field labels through the generated SDK adapter
  • preserve labels in display-safe JSON metadata
  • keep stable field names authoritative for state, updates, and browser fill
  • update CLI guidance and examples for labels and ordered definitions
  • test labeled and unlabeled metadata, order preservation, and name-keyed update/fill behavior

rollout

kernel/kernel#4214 is deployed, and this PR now uses the published kernel-go-sdk@v0.110.0 release.

testing

  • make test
  • make build
  • git diff --check

Note

Low Risk
Display-metadata and SDK bump only; field names remain authoritative and existing secret redaction behavior is unchanged.

Overview
Adds optional human-readable label on vault credential field definitions while keeping name as the stable key for collection state, updates, and browser fill.

The CLI now passes labels through the kernel-go-sdk v0.110.0 credential create/update flow, includes label in filtered vault JSON output for spec.fields, and updates README plus vaults credentials help/examples to document label vs. name behavior. Tests and steering assertions cover labeled and unlabeled fields, definition order, and that public output still redacts sensitive values.

Reviewed by Cursor Bugbot for commit 57c299b. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security

socket-security Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​kernel/​kernel-go-sdk@​v0.109.0 ⏵ v0.110.073 +1100100100100

View full report

@rgarcia rgarcia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed incrementally — looks good. credential labels remain display-only metadata, while stable field names continue to drive updates, state, and browser fills. tests cover SDK serialization, safe output, ordering, redaction, and labeled/unlabeled fields.

@masnwilliams
masnwilliams merged commit 41138f8 into main Sep 18, 2026
8 checks passed
@masnwilliams
masnwilliams deleted the hypeship/credential-field-labels branch September 18, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants