Preserve credential field order - #261
Merged
Merged
Conversation
rgarcia
approved these changes
Sep 17, 2026
rgarcia
left a comment
Contributor
There was a problem hiding this comment.
reviewed — implementation looks good and follows the architecture agreed in the related API PRs. two follow-ups:
rollout
go.mod:12— the preview SDK pin is fine for merge provided this PR merges afterkernel/kernel#4163; once the official SDK is released, please follow up with a PR replacing the preview pin.
tests
cmd/vaults_public_values_test.go:17-42— non-blocking: create order is covered, but nothing asserts that display-safe JSON preservesspec.fieldsorder. could we decode one output and assert the field-name sequence?
Contributor
Author
|
added the suggested display-safe output test; it now decodes the projected credential item and asserts the exact field-name sequence. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
rgarcia
approved these changes
Sep 17, 2026
masnwilliams
force-pushed
the
hypeship/order-vault-fields
branch
from
September 17, 2026 20:35
d861b64 to
dda95bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vaults credentials createRollout
Testing
go test ./...Note
Medium Risk
Breaking change for
credentials createJSON (map → ordered array) tied to a preview SDK/API rollout; touches credential spec handling and public value redaction, though update/fill paths are largely unchanged.Overview
Credential create specs now use an ordered
fieldsarray ([{"name":"username",...}]) instead of a name-keyed object, matching the updated Go SDK preview. Array order is preserved in display-safe JSON output and drives the hosted collection form layout.Help text and README vault examples now tell callers to list fields in the site’s natural top-to-bottom order.
preservePublicCredentialValuesandvaultItemFieldswere updated for the array shape; tests and fixtures follow suit, including a check that definition order survives filtering. Credential update specs remain map-based for partial value changes.go.modpinskernel-go-sdkto a generated preview (kernel/kernel#4163) until a coordinated release replaces it with a published version.Reviewed by Cursor Bugbot for commit dda95bf. Bugbot is set up for automated code reviews on this repo. Configure here.