Skip to content

Add proper bottom spacing to h1 to prevent divider overlap#789

Open
DARSHAN-R-DARSHAN wants to merge 1 commit intokeploy:mainfrom
DARSHAN-R-DARSHAN:fix/overlap
Open

Add proper bottom spacing to h1 to prevent divider overlap#789
DARSHAN-R-DARSHAN wants to merge 1 commit intokeploy:mainfrom
DARSHAN-R-DARSHAN:fix/overlap

Conversation

@DARSHAN-R-DARSHAN
Copy link
Copy Markdown

@DARSHAN-R-DARSHAN DARSHAN-R-DARSHAN commented Feb 12, 2026

Fix: keploy/keploy#3776

What I did

  • Fixed the improper spacing between h1 and div
  • Checked locally if it works

Signed-off-by: DARSHAN-R-DARSHAN <darshanramanji07@gmail.com>
@DARSHAN-R-DARSHAN
Copy link
Copy Markdown
Author

Hi team, please review this when you have a chance. Thanks!

Copy link
Copy Markdown
Member

@amaan-bhati amaan-bhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up and for the clear description of the issue being fixed. The problem is well understood and the approach is on the right track.

Issues Found

1. CSS specificity issue

The file already contains:

article.markdown h1 {
  margin-bottom: 1rem;
}

Since article.markdown h1 is more specific than the general h1 rule being added here, the more specific rule wins and the fix will likely not apply where the bug actually occurs. Please update the selector to article.markdown h1 to ensure the fix applies in the correct context.

2. Padding side effects

Adding padding-bottom directly to h1 can affect layouts that rely on the h1 box model for positioning. Please test across multiple doc pages to confirm no unintended layout shifts.

3. No visual evidence

Please provide a screenshot or short video showing the bug and the fix.

Please also rebase against main before resubmitting as there are merge conflicts with other open PRs touching the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Heading text overlaps with divider line on documentation pages

2 participants