RecommendationでADT再出題問題の出典と問題番号を修正 - #1563
Open
blueberry1001 wants to merge 1 commit into
Open
blueberry1001 wants to merge 1 commit into
blueberry1001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommendationで、ADTに再出題された問題のContestとProblem欄にADT側の情報が表示される不具合を修正します。例えば
abc212_eが「ADT / H. Safety Journey」ではなく「ABC212 / E. Safety Journey」と表示されるようになります。ADTに紐づいた問題について、問題IDから得た元のコンテスト候補を
contest-problem.jsonの対応情報で確認し、出典と問題番号を復元します。問題名は復元後の番号とnameから表示し、問題リンクとコンテストカテゴリの絞り込みにも同じ情報を使用します。対応情報が取得できない場合は元のデータを維持します。#1553 はクロール時の上書きを防ぐ修正ですが、このPRはすでに上書きされたデータに対するRecommendation画面の表示修正です。データベースの更新や他画面の修正は含みません。
確認内容:
react-scripts build)が成功しました。abc212_eと検証用のユーザーデータで、表示・リンク先・ABCフィルターへの切り替えを確認しました。コンソールエラーはありませんでした。