fix(config): open the oauth-url link in the browser and print it unwrapped (SUPPORT-17391) - #726
Draft
ZoraJel wants to merge 2 commits into
Draft
fix(config): open the oauth-url link in the browser and print it unwrapped (SUPPORT-17391)#726ZoraJel wants to merge 2 commits into
ZoraJel wants to merge 2 commits into
Conversation
…apped (SUPPORT-17391) Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…block (SUPPORT-17391) Co-Authored-By: Zora Jelínková <zora.jelinkova@keboola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORT-17391:
config oauth-urlprints a ~200-char URL, so it fits no terminal row, and the wrapped copy is what users actually follow. Two layers truncate it — Rich inserted real newlines at the console width, and terminals/chat renderers autodetect URLs per visual row — and both lose the config id in the trailing#/<component>/<config>fragment while keepingtoken/sapiUrl. The wizard therefore authenticates and then 404s on the configuration, reportingFailed to load config data. Please contact us on support@keboola.com, which reads like a broken OAuth flow.Nothing printed can fix a renderer we don't control, so the command opens the link itself and keeps the text as a copy fallback:
_should_openis interactive-only:--jsonreturns before it, a non-terminal stdout (pipe, CI,serve) never opens a window, and--no-openopts out when authorizing on another machine. JSON output is unchanged.auth.environment.open_browsergains the WSL branch it lacked.webbrowserkeys its Windows handling offsys.platform == "win32", which islinuxinside WSL, so it either resolved no handler (→False, no browser) or opened a Linux-side browser with a separate profile that shares none of the logins the flow needs.wslviewwas already probed here for the login-flow heuristics but never used to open anything:Skill docs: a new
references/oauth-workflow.md(generate → consent → verifyoauth_api.versionbumped) whose reporting rule is the other half of the fix — an agent answering in chat must echo the URL in a fenced code block, never as inline prose, because that is the surface where per-row link detection truncates it. Plus theoauth-urlrow incommands-reference.mdand a gotchas entry recording the symptom.Unchanged on purpose: the 1 h token TTL (the UI mints 48 h) and the absence of a config preflight before minting.
Release Notes
Justification, description
kbagent config oauth-urlhanded out a link that terminals and chat renderers truncate at the first visual row, dropping the configuration id and failing in the browser with "Failed to load config data". The command now opens the link in the default browser itself (interactive use only;--no-opento suppress) and prints the complete URL unwrapped. Includes a WSL fix so the Windows-side default browser is used instead of none, and a skill workflow telling agents to echo the URL in a fenced code block.Plans for Customer Communication
N/A
Impact Analysis
config oauth-urlin interactive human mode now opens a browser window as a side effect.--jsonand non-terminal stdout are unaffected, so scripted, piped and server callers see no change; the response payload is identical.Deployment Plan
Ships with the next
kbagentrelease.Rollback Plan
Revert the commits;
--no-openreproduces the previous behavior in the meantime.Post-Release Support Plan
N/A
Link to Devin session: https://app.devin.ai/sessions/e0d8eb25504b4b7cb6b1f9c354d448e3
Open in Devin Desktop: https://app.devin.ai/desktop/session/e0d8eb25504b4b7cb6b1f9c354d448e3?variant=devin
Requested by: @ZoraJel