Update KIDL code to the most recent kb_sdk_plus version.#7
Merged
MrCreosote merged 2 commits intodevelopfrom Mar 31, 2025
Merged
Update KIDL code to the most recent kb_sdk_plus version.#7MrCreosote merged 2 commits intodevelopfrom
MrCreosote merged 2 commits intodevelopfrom
Conversation
KIDL code should next be removed from kb_sdk_plus and a jar from this repo used instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7 +/- ##
=============================================
+ Coverage 61.50% 62.14% +0.63%
- Complexity 634 689 +55
=============================================
Files 35 37 +2
Lines 2816 2953 +137
Branches 554 539 -15
=============================================
+ Hits 1732 1835 +103
- Misses 897 931 +34
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MrCreosote
commented
Mar 27, 2025
Comment on lines
-5
to
-6
| * Similarly, the HTML generation code should be moved into the KIDL code, perhaps in | ||
| `kidlhtml` or `kidl.html`. |
Member
Author
There was a problem hiding this comment.
Changed my mind here, if anything it should be moved to its own package, but for now leaving it in the SDK is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIDL code should next be removed from kb_sdk_plus and a jar from this repo used instead.