Record why the cluster capture needs no verify gate - #527
Closed
Rachael-Graham wants to merge 1 commit into
Closed
Rachael-Graham wants to merge 1 commit into
Rachael-Graham wants to merge 1 commit into
Conversation
Docs preview
Both are uploaded Worker versions and serve no production traffic. |
The capture step needs no verify gate. A bare `--update-snapshots` presets `changed` in the pinned 1.63.0, which rewrites only baselines that fail the comparison, and the comparison applies `maxDiffPixelRatio: 0.01`. Also corrects the trigger comment: a refresh PR that edits a spec does re-trigger this workflow, and the hosted runner is no longer unproven. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Rachael Graham <rachael.graham@solo.io>
Rachael-Graham
force-pushed
the
gate-cluster-capture
branch
from
September 24, 2026 17:18
dc493f0 to
33b72bc
Compare
Rachael-Graham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only. The parsed workflow is byte-identical to
main.The gate this PR originally added was unnecessary. It claimed
update:*consults no tolerance. It does.node_modules/playwright/lib/program.jspresets a bare--update-snapshotstochanged, andmatchers/expect.jswrites under that mode only when the comparison returns an error — the comparison that appliesplaywright.config.ts'smaxDiffPixelRatio: 0.01. Only--update-snapshots=allfalls back to a raw byte comparison.Evidence from the two runs either side of #526.
mainThe second run stood up a fresh kind cluster, so it had a new ReplicaSet hash, a new pod IP and a moving
read N agoline, and committed none of them. The recurring contentless PR stopped when the Linux baselines landed, not for want of a gate.What is left here. The reasoning above, recorded on the capture step, plus two corrections to the cluster job's header comment: a refresh PR that also edits a spec does re-trigger this workflow, since
tests/**is on the path filter — #523 editedchat.spec.tsand its merge started the run that produced #526 — and the hosted runner is no longer unproven.🤖 Generated with Claude Code