Merged
Conversation
When a port with hostID set is attached to a server, OpenStack rebinds the port to the actual compute host, creating drift between the ORC spec and reality. The controller would then fight by trying to push the spec value back. Make hostID immutable via CEL validation to prevent this inconsistency. Remove the now-dead hostID update path from the controller and the port-update-admin e2e test that exercised it. Fixes k-orc#659.
Contributor
|
Copying and pasting the comment from the related issue
Am I missing something? Despite the comment, the changes look good to me. |
Add a note to the hostID field documentation warning that OpenStack may rebind the port to the server's actual compute host, which may differ from the specified hostID if no matching scheduler hint is used.
Collaborator
Author
Good, I've added a comment explaining the host ID might differ in the status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a port with hostID set is attached to a server, OpenStack rebinds the port to the actual compute host, creating drift between the ORC spec and reality. The controller would then fight by trying to push the spec value back.
Make hostID immutable via CEL validation to prevent this inconsistency. Remove the now-dead hostID update path from the controller and the port-update-admin e2e test that exercised it.
Fixes #659.