Simplify dependency ready filters to use IsAvailable directly#674
Open
mandre wants to merge 1 commit intok-orc:mainfrom
Open
Simplify dependency ready filters to use IsAvailable directly#674mandre wants to merge 1 commit intok-orc:mainfrom
mandre wants to merge 1 commit intok-orc:mainfrom
Conversation
Collaborator
Author
|
I'll split this PR into 2 changes to avoid the fix being part of a breaking change. |
Collaborator
Author
|
Backward compatible PR submitted here. I'll repurpose this one for the cleanup, that we'll merge later. |
Since IsAvailable implies Status.ID is set, the redundant check for Status.ID != nil can be removed. Made IsAvailable generic to allow passing it directly as a filter function, eliminating boilerplate lambdas across all controllers. This makes the code more concise and ensures consistent availability checking for all dependencies.
mandre
force-pushed
the
ensure-deps-available
branch
from
0e71cc5 to
712780b
Compare
mandre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since IsAvailable implies Status.ID is set, the redundant check for
Status.ID != nil can be removed. Made IsAvailable generic to allow
passing it directly as a filter function, eliminating boilerplate
lambdas across all controllers.
This makes the code more concise and ensures consistent availability
checking for all dependencies.