Skip to content

README is missing the Props section - #30

Closed
amowu wants to merge 1 commit into
jwplayer:mainfrom
amowu:patch-1
Closed

README is missing the Props section#30
amowu wants to merge 1 commit into
jwplayer:mainfrom
amowu:patch-1

Conversation

@amowu

@amowu amowu commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

This PR will...

Add the Props section back in, and correct its sub-sections.

Why is this Pull Request needed?

Clicking Props link on ToC doesn't jump to the Props section.

Are there any points in the code the reviewer needs to double check?

N/A

Are there any Pull Requests open in other repos which need to be merged with this?

N/A

Addresses Issue(s):

N/A

Correct the Table of Contents which has "props" section, but clicking on it doesn't jump to the corresponding section."
@jwplayer-robot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@jwbrandon

Copy link
Copy Markdown
Contributor

Thanks @amowu — good catch, the Contents list was linking to a #props anchor that did not exist.

This branch had drifted out of mergeable state, so I rebuilt the same change on top of current main in #38 and credited you via Co-authored-by. Closing in favor of that.

@jwbrandon jwbrandon closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants