Skip to content

fix(rps): skip spot H3-H3 peer when YARP SLO-fails (7.0.4-beta) #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justcoding121 merged 1 commit into from
Sep 1, 2026
Merged

fix(rps): skip spot H3-H3 peer when YARP SLO-fails (7.0.4-beta) #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tools/RpsLoadProbe/run-spot-matrix.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# PR2 local spot gate: compare-spot @ c=64, validate Full÷Reverse >= 0.70 and reverse TWP÷YARP >= 0.95.
# Spot gate: compare-spot @ c=64, Full÷Reverse >= 0.70 and reverse TWP÷YARP >= 0.95.
# Skip TWP÷YARP when YARP did not SLO-pass (same policy as validate-compare-product-gates.ps1).
[CmdletBinding()]
param(
[int] $Concurrency = 64,
Expand Down Expand Up @@ -79,6 +80,17 @@ foreach ($pair in $mitmPairs) {
}

foreach ($pair in $reversePairs) {
if (-not $rpsAtC.ContainsKey($pair.Twp)) {
Write-Host ("FAIL {0}: missing TWP arm data" -f $pair.Label) -ForegroundColor Red
$failed = $true
continue
}
if (-not $rpsAtC.ContainsKey($pair.Yarp)) {
# Match validate-compare-product-gates.ps1: YARP H3→H3 often 0 RPS / SLO-fail on
# Linux GHA (peer harness), not a TWP regression — skip peer ratio when YARP absent.
Write-Host ("SKIP {0}: no YARP SLO-pass peer (TWP present)" -f $pair.Label) -ForegroundColor DarkYellow
continue
}
$ratio = Get-Ratio $pair.Twp $pair.Yarp
if ($null -eq $ratio) {
Write-Host ("FAIL {0}: missing arm data" -f $pair.Label) -ForegroundColor Red
Expand Down
Loading