Repository navigation
Conversation
odow
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We spend time doing
map_indiceseven though this mapping is often trivial! As side benefit, it prevents thecopyfrom destroying aliasing information and, if we go for #2802, that dictionary won't get filled if the variable mapping is trivial.Does MOI assume map_indices copies?
No. The docstring never promised a copy, and index-free values (ObjectOrTupleOrArrayWithoutIndex, ScalarConstantChange) are already returned without copying. We have the convention in MOI that when a models receive a something, it needs to copy it. But we do not also need to give copies otherwise we're just copying on both sides. So just returning the object without copying is fine if the mapping is trivial.