Conversation
Member
Author
|
This is consistent with ParametricOptInterface which does some magic if it takes an optimizer constructor as argument but when it takes an instantiated optimizer, it does not modify it. |
Member
|
Interesting, |
Member
Author
Yes, I think we should discuss this, and it should also go in parallel with the layer design that @odow suggested in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit counter intuitive to still add caches and bridges when the user explicitly give an instantiated model. I guess the use case is the
DualizableModelbut maybe we don't need this. We're using aUniversalFallbackon top of it anyway so what's the use for it instead of justMOI.Utilities.Model?