Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
- Coverage 94.73% 90.20% -4.54%
==========================================
Files 13 13
Lines 703 745 +42
==========================================
+ Hits 666 672 +6
- Misses 37 73 +36 ☔ View full report in Codecov by Sentry. |
| ::MOI.VariablePrimalStart, | ||
| ::Type{MOI.VariableIndex}, | ||
| ) | ||
| return true |
There was a problem hiding this comment.
This needs to check whether the inner optimizer supports ConstraintDualStart
There was a problem hiding this comment.
It's a bit tricky because we don't know the type of constraints. The inner may not support equality constraints in which case we cannot even ask for whether the solver supports ScalarAffineFunction-in-EqualTo
There was a problem hiding this comment.
Yeah I don't know what a good answer is here
There was a problem hiding this comment.
I think I have an idea that I'll try next week
There was a problem hiding this comment.
Ff we set the VariablePrimalStart then it is for the free variables. If we have constrained variables, then we should probably set the starting value to the constraint.
src/MOI_wrapper.jl
Outdated
| ::Union{MOI.ConstraintDualStart,MOI.ConstraintPrimalStart}, | ||
| ::Type{<:MOI.ConstraintIndex}, | ||
| ) | ||
| return true |
There was a problem hiding this comment.
Needs to check the inner optimizer supports VariablePrimalStart. I don't know if ConstraintPrimalStart makes sense to support?
| end | ||
|
|
||
| function _dual_attribute( | ||
| ::Union{MOI.VariablePrimalStart,MOI.ConstraintPrimalStart}, |
There was a problem hiding this comment.
I know know that it makes sense to support MOI.ConstraintPrimalStart?
|
Rebasing this branch was difficult so I started in a new branch and kept this one in case I forgot something: #208 |
2 participants
This also fixes a bug: the
result_indexwere ignored and we would invariably query the first solution.result_indexbugCloses #165