Repository navigation
Conversation
- Wait for _sync to finish submitting resolvers before ending the sync - Yield every message left after the post-sync hook - Track the resolver scope in a ContextVar so copied contexts keep it - Schedule a flush's checkpoints all or none - Accept non-string client ids in state_key - Drop unused _Pending.sent and the redundant root scope in _sync
A Scheduler reused across syncs kept resolvers of a cancelled sync running. Their flushes went onto the next sync's stream, so the CLI could persist cursors past the rows it committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the early sync exit race, keeps every message drained after the post-sync hook, tracks resolver scopes in a ContextVar, schedules a flush's checkpoints atomically, rejects checkpoints from resolvers of an ended sync, and accepts non-string client ids in
state_key(follow-up to cloudquery#415).