Skip to content

Fix handling of temporary private forks - #548

Open
Jackenmen wants to merge 1 commit into
josegonzalez:masterfrom
Jackenmen:handle_temporary_private_forks
Open

Jackenmen wants to merge 1 commit into
josegonzalez:masterfrom
Jackenmen:handle_temporary_private_forks

Conversation

@Jackenmen

Copy link
Copy Markdown

Fixes #547

The biggest change involves fetching PR comments - per https://github.com/orgs/community/discussions/213137 /repos/{owner}/{repo}/issues/{issue_number}/comments does not work on temporary private forks. Instead, I switched comment retrieval for pull requests to use a GraphQL query. The same data should be present in both old REST API and new GraphQL API implementation but the way it's structured into fields is not the same for some information. I used the implementation for discussion comments as a starting point so let me know, if there's any other field from IssueComment that you think is worth including.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when trying to backup a temporary private fork

1 participant