Serialize concurrent writes to the same filepath (Fixes #13) - #16
Open
dyk1454683243-sudo wants to merge 2 commits into
Open
dyk1454683243-sudo wants to merge 2 commits into
dyk1454683243-sudo wants to merge 2 commits into
Conversation
Queue write() calls per resolved destination path so overlapping async writes cannot interleave or tear the file. write.sync still uses writeFileSync and adds a queue barrier for later write()s. Fixes jonschlinkert#13 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
dyk1454683243-sudo
marked this pull request as ready for review
September 20, 2026 19:51
write.sync already completes atomically via writeFileSync. Appending a no-op to the async queue on each sync write would grow a microtask chain in tight loops used by callers such as flat-cache. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
Two overlapping
write()calls to the same path can interleave: a later, smaller write may finish first, then an earlier large write overwrites it (or a reader sees a torn/corrupted file).Change
In-process promise queue keyed by
path.resolve(destpath)sowrite()calls targeting the same file run serially. Last-queued write wins after serialization.write.syncis unchanged (writeFileSynccompletes before returning, so two sync writes cannot interleave). Public API, overwrite/increment/mkdir behavior, and dependencies are unchanged.Tests