Fix increment:true creating foo (2).txt on empty directories - #15
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
add-filename-increment only checks existence when `fs: true`.
Without that, Windows incrementing starts at 2, so the first
write with `{ increment: true }` created `foo (2).txt` instead
of `foo.txt`. Pass `fs: true` when incrementing and leave
non-increment writes unchanged.
Fixes jonschlinkert#11
Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write.sync('foo.txt', 'some data', { increment: true })on an empty directory currently createsfoo (2).txton Windows instead offoo.txt.add-filename-incrementonly checks whether the destination exists whenoptions.fs === true. Without that, the Windows formatter starts at2and always emitsfoo (2).txt. The workaround in #11 ({ increment: true, fs: true }) works for that reason.Change
When
options.incrementis set, passfs: trueintoadd-filename-incrementso existence checks run. Default non-increment writes are unchanged. The caller’s options object is no longer mutated.Tests
platform: 'win32'keepsfoo.txtfor async, sync, and streamfoo (2).txt/foo (3).txtFixes #11