feat(usergroups): add missing team_id argument to usergroups.users.list - #191
Open
maartenpaauw wants to merge 1 commit into
Open
feat(usergroups): add missing team_id argument to usergroups.users.list#191maartenpaauw wants to merge 1 commit into
maartenpaauw wants to merge 1 commit into
Conversation
Member
|
Hello, thank for you contribution, it looks good! I just updated the SDK on |
The `team_id` query parameter is documented by Slack as an optional
argument for `usergroups.users.list` ("The user group's encoded team ID.
Required if org token is used."), but it was absent from the patched
OpenAPI spec, so the generated endpoint rejected it with an
UndefinedOptionsException.
Add it to resources/slack-openapi-patched.json (matching the existing
team_id override on usergroups.list), refresh the community patch file,
and regenerate the affected endpoint code.
Ref: https://docs.slack.dev/reference/methods/usergroups.users.list
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CXAVNUu5y3nHkfzq2TdNfX
maartenpaauw
force-pushed
the
feat/usergroups-users-list-team-id
branch
from
August 31, 2026 06:37
d6e23bd to
74f38e9
Compare
Author
|
@damienalexandre thanks for the quick response! I've rebased my branch and it is up-to-date with main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slack documents
team_idas an optional argument forusergroups.users.list:It's missing from the patched OpenAPI spec, so the generated endpoint rejects it:
usergroups.listalready carries this same override — this bringsusergroups.users.listin line.What
team_idquery parameter to/usergroups.users.listinresources/slack-openapi-patched.jsonresources/slack-openapi-sorted.patch(new hunk + cascaded hunk offsets, same shape as Add team_id support for 3 endpoints #140)generated/Endpoint/UsergroupsUsersList.php,generated/Client.phpdocblock)Verification
slack-openapi-sorted.jsonand reproducesslack-openapi-patched.jsonexactlygenerated/diff is limited to what a full Jane regen produces for this spec changeJsonSorterTestpasses (patched spec still correctly sorted)php-cs-fixer --dry-runcleanNote on
check-specA full
jane-openapi generatewith the current latest Jane also rewrites a large number of unrelatedNormalizer/BaseEndpointfiles (Jane template drift since the last full rebuild in #189). That churn is intentionally not included here so this PR stays scoped toteam_id. Ifcheck-specfails on that unrelated diff, it reflects the pre-existing Jane-version drift onmainrather than this change — happy to rebase once the SDK is rebuilt.