Skip to content

Accept statically proven safe uncontrolled changes - #8

Merged
johnsonlee merged 1 commit into
mainfrom
feat/static-safety-proofs
Nov 15, 2026
Merged

johnsonlee merged 1 commit into
mainfrom
feat/static-safety-proofs

Conversation

@johnsonlee

@johnsonlee johnsonlee commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

GraphFold can now accept an uncontrolled production change when a complete static equivalence proof covers every remaining difference. Acceptance preserves the UNCONTROLLED classification; changing a return value, introducing an unsafe dereference or effect, or leaving a proof unresolved still fails.

The engine propagates nullness and resolved-call summaries, checks effects and termination independently, and retains production instructions outside the paths traversed by the proof. Original-bytecode summaries cannot override selected control folds, including folds in resolved inherited methods and class initializers used by the proof. The same properties strengthen redundant A/B exposure-predicate handling. An explicit folds: [] supports analysis without selected controls.

Report schema v2 separates control coverage, cited safety evidence, and the acceptance decision. Java/Kotlin golden cases cover Spring Boot JAR and WAR inputs, with independent assertions for proof subjects, diagnostic messages, control classification and verdict. Class inventory comparison also normalizes compiler-generated inner-class record ordering while preserving membership and access flags.

Validation: 148 affected regression tests pass locally, including all 99 safety goldens and four reproduced inherited-method/initializer dependency failures that now reject reuse of the original proof. An additional 47 prepared-input goldens pass, with independent control, safety and acceptance assertions for uninvoked lambdas, unconsumed Streams and unused production changes, alongside controlled counterparts. Engine main/test lint passes. All 13 checks in the full Build workflow pass on this commit, including Ubuntu/macOS test shards, exact 100% line and branch coverage gates for every module, publication checks, and native Maven library, Boot JAR and WAR lifecycle verification.

Closes #6.

@johnsonlee
johnsonlee force-pushed the feat/static-safety-proofs branch 2 times, most recently from cf83811 to c13001f Compare November 14, 2026 13:18
@johnsonlee
johnsonlee force-pushed the feat/static-safety-proofs branch from c13001f to b2316e1 Compare November 14, 2026 13:30
@github-actions

Copy link
Copy Markdown

Unit test coverage: Passed

Commit b2316e1742a8e71b18ea5dfb89cc716469052ec3 · Build run 43600114772, attempt 1

Required for every module on both platforms: 100% line and 100% branch coverage. A pass requires zero missed lines/branches and nonzero measured totals.

Platform Verification
ubuntu-latest Passed
macos-latest Passed
Module Platform Line Branch
engine ubuntu-latest 100% (6717/6717) 100% (6790/6790)
engine macos-latest 100% (6717/6717) 100% (6790/6790)
gfc ubuntu-latest 100% (479/479) 100% (368/368)
gfc macos-latest 100% (479/479) 100% (368/368)
plugin/gradle ubuntu-latest 100% (172/172) 100% (76/76)
plugin/gradle macos-latest 100% (172/172) 100% (76/76)
plugin/maven ubuntu-latest 100% (108/108) 100% (90/90)
plugin/maven macos-latest 100% (108/108) 100% (90/90)

Coverage reports describe this run; missing or invalid reports never count as 100%. The required run-unit-test check also requires all tests and verification steps to succeed.

@johnsonlee
johnsonlee marked this pull request as ready for review November 14, 2026 14:52

@johnsonlee johnsonlee left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance design matches AGENTS.md. Acceptance requires a relational proof that the BASE and HEAD return expressions are identical, plus effect-free, nonthrowing and terminating proofs on both sides. The change stays classified UNCONTROLLED. Any non-method difference or gap rejects. Folded dependencies can't be reused. Integer normalization is limited to exact constant folding and identities with 0 and 1, and floats stay unknown.

One false-PASS path remains (inline): reference equality is inferred from identical expressions, and boxing contracts make two distinct objects share an expression.


Generated by Claude Code

@johnsonlee
johnsonlee merged commit 2c4a70c into main Nov 15, 2026
13 checks passed
@johnsonlee
johnsonlee deleted the feat/static-safety-proofs branch November 15, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prove static safety of uncontrolled production-code changes

1 participant