Repository navigation
Accept statically proven safe uncontrolled changes - #8
Conversation
cf83811 to
c13001f
Compare
c13001f to
b2316e1
Compare
Unit test coverage: PassedCommit Required for every module on both platforms: 100% line and 100% branch coverage. A pass requires zero missed lines/branches and nonzero measured totals.
Coverage reports describe this run; missing or invalid reports never count as 100%. The required |
johnsonlee
left a comment
There was a problem hiding this comment.
The acceptance design matches AGENTS.md. Acceptance requires a relational proof that the BASE and HEAD return expressions are identical, plus effect-free, nonthrowing and terminating proofs on both sides. The change stays classified UNCONTROLLED. Any non-method difference or gap rejects. Folded dependencies can't be reused. Integer normalization is limited to exact constant folding and identities with 0 and 1, and floats stay unknown.
One false-PASS path remains (inline): reference equality is inferred from identical expressions, and boxing contracts make two distinct objects share an expression.
Generated by Claude Code
GraphFold can now accept an uncontrolled production change when a complete static equivalence proof covers every remaining difference. Acceptance preserves the
UNCONTROLLEDclassification; changing a return value, introducing an unsafe dereference or effect, or leaving a proof unresolved still fails.The engine propagates nullness and resolved-call summaries, checks effects and termination independently, and retains production instructions outside the paths traversed by the proof. Original-bytecode summaries cannot override selected control folds, including folds in resolved inherited methods and class initializers used by the proof. The same properties strengthen redundant A/B exposure-predicate handling. An explicit
folds: []supports analysis without selected controls.Report schema v2 separates control coverage, cited safety evidence, and the acceptance decision. Java/Kotlin golden cases cover Spring Boot JAR and WAR inputs, with independent assertions for proof subjects, diagnostic messages, control classification and verdict. Class inventory comparison also normalizes compiler-generated inner-class record ordering while preserving membership and access flags.
Validation: 148 affected regression tests pass locally, including all 99 safety goldens and four reproduced inherited-method/initializer dependency failures that now reject reuse of the original proof. An additional 47 prepared-input goldens pass, with independent control, safety and acceptance assertions for uninvoked lambdas, unconsumed Streams and unused production changes, alongside controlled counterparts. Engine main/test lint passes. All 13 checks in the full Build workflow pass on this commit, including Ubuntu/macOS test shards, exact 100% line and branch coverage gates for every module, publication checks, and native Maven library, Boot JAR and WAR lifecycle verification.
Closes #6.