Remove Python 3.9 support - #255
Merged
Merged
Conversation
DeaMariaLeon
marked this pull request as ready for review
September 21, 2026 16:02
ogrisel
approved these changes
Sep 21, 2026
ogrisel
left a comment
ogrisel
left a comment
Contributor
There was a problem hiding this comment.
Thanks @DeaMariaLeon. LGTM once the following is addressed.
| [tool.black] | ||
| line-length = 88 | ||
| target_version = ['py39', 'py310', 'py311', 'py312', 'py313'] | ||
| target_version = ['py310', 'py311', 'py312', 'py313'] |
Contributor
There was a problem hiding this comment.
We can probably add 'py314' and maybe even 'py315' to the mix.
Contributor
Author
There was a problem hiding this comment.
To add 'py314' I had to change black's pinned version and change a text format in threadpoolctl.py to make the CI happy.
ogrisel
approved these changes
Sep 22, 2026
Contributor
|
Thanks for the PR. Maybe we could switch to ruff if you are interested in doing a follow-up contrib. |
Contributor
Author
|
Yes, sure. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #238
It looks like
blackpinned version 25.1.0 doesn't support Python 3.14,so I didn't add it.https://github.com/psf/black/blob/25.1.0/src/black/mode.py