Skip to content

Return null when a slice step is 0 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyanu2507 wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −2
Open

Return null when a slice step is 0 #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jmespath/visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,11 @@ def visit_index_expression(self, node, value):
def visit_slice(self, node, value):
if not isinstance(value, list):
return None
s = slice(*node['children'])
return value[s]
try:
s = slice(*node['children'])
return value[s]
except ValueError:
return None

def visit_key_val_pair(self, node, value):
return self.visit(node['children'][0], value)
Expand Down
3 changes: 3 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,6 @@ def test_can_handle_decimals_as_numeric_type(self):
result = decimal.Decimal('3')
self.assertEqual(jmespath.search('[?a >= `1`].a', [{'a': result}]),
[result])

def test_zero_step_slice_returns_none(self):
self.assertIsNone(jmespath.search('[::0]', [1, 2, 3]))