Support Rescript v12 literal regex, experimental tree-sitter mode and autoload compilation rx#18
Open
mvaled wants to merge 3 commits intojjlee:masterfrom
Open
Support Rescript v12 literal regex, experimental tree-sitter mode and autoload compilation rx#18mvaled wants to merge 3 commits intojjlee:masterfrom
mvaled wants to merge 3 commits intojjlee:masterfrom
Conversation
- Add regex-literal detection regex to properly handle /regex/ literals - Add syntax-propertize-function to mark / delimiters as string fences - This ensures quotes inside regexes don't break syntax parsing
- Tree-sitter based major mode for ReScript - Provides syntax highlighting and indentation powered by tressister - Uses the upstream Rescript grammar from the ReScript team - Note: Experimental - current upstream grammar doesn't support dict syntax (ReScript v11.1+) or Rescript v12 yet - To enable, add rescript-ts-mode manually after loading the package
The rescript error/warning patterns were registered at load time of rescript-mode, but compilation-mode may parse the buffer before any .res file is opened. Wrap the registration in with-eval-after-load and add autoload cookies so the patterns are available as soon as compile.el is loaded.
mvaled
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 3 different improvements:
.resfile) and compile, the errors won't be properly detected becauserescript-modeis not loaded yet.