Repository navigation
fix: treat comment-like tokens inside text blocks as string fragments - #1128
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
In
tree-sitter-java-orchard,multiline_string_fragmentis not marked astoken.immediate, so comment tokens (block_commentandline_comment) inextrascan match inside text blocks when a comment-like line contains"or\(which stopsmultiline_string_fragmentearly and lets the comment rule win by longest match). This causedprocessTreeto collect those inner tokens intoast.comments, leading Prettier to fail withComment "..." was not printed(or omit the fragment when printing interpolated text blocks).Comment nodes whose parent is a
string_literalare now treated asmultiline_string_fragmentnodes rather than comments.Example
Input
Output
Relative issues or prs:
Closes #1112