Skip to content

Align User-Agent tests with IDE-only client identity - #3675

Open
sverdlov93 wants to merge 3 commits into
masterfrom
feature/ide-only-client-identity
Open

Align User-Agent tests with IDE-only client identity#3675
sverdlov93 wants to merge 3 commits into
masterfrom
feature/ide-only-client-identity

Conversation

@sverdlov93

Copy link
Copy Markdown
Contributor

Overview

jfrog-cli User-Agent tests now match IDE-only ai-client/ and the tightened session detectors. This PR does not bump jfrog-cli-core yet.

Details

  • Cursor agent cases expect ai-agent/cursor ai-client/cursor.
  • Copilot VS Code alias, kilo-extension omit, and human CLAUDECODE omit cases are covered.
  • Detector env lists are cleared so tests do not leak host IDE or agent vars.
flowchart LR
  core[jfrog-cli-core detectors] --> ua[GetCliUserAgent]
  ua --> tests[CLI unit tests]
Loading

Notes

Do not merge until the companion jfrog-cli-core PR is merged and this repo bumps the core module. Local replace was not committed. CI will keep using published core until that bump.

Cursor sessions now expect ai-client/cursor; Copilot aliases and kilo-extension omit cases are covered without bumping unpublished core.
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Aug 19, 2026
IDE-only client must not follow the terminal program when COPILOT_CLI is set.
Zed, JetBrains and VS Code forks all advertise themselves through env, so an
unisolated test run inside one of those editors would leak its window into the
User-Agent assertions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant