Skip to content

XRAY-157755 - Fix insecure tls flag traversal for maven projects - #846

Open
gauriy-tech wants to merge 2 commits into
jfrog:devfrom
gauriy-tech:feature/XRAY-157755-fix-mvn-dep-ntw-issue
Open

XRAY-157755 - Fix insecure tls flag traversal for maven projects#846
gauriy-tech wants to merge 2 commits into
jfrog:devfrom
gauriy-tech:feature/XRAY-157755-fix-mvn-dep-ntw-issue

Conversation

@gauriy-tech

@gauriy-tech gauriy-tech commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

What & why

curation-audit/audit spawn a real mvn subprocess to build the dependency tree. Two bugs made
this fail silently for customers behind a TLS-intercepting proxy:

  • --insecure-tls never reached that subprocess — DepTreeParams had no field for it.
  • The real Maven error was swallowed behind log.Verbose (above DEBUG); only exit status 1 ever surfaced.

Changes

  • Thread InsecureTls through DepTreeParamsMavenDepTreeManager → the spawned mvn command.
  • Append both Wagon and native-resolver TLS-bypass properties (-Dmaven.wagon.http.ssl.* and
    -Daether.connector.https.securityMode=insecure), since Maven 3.9+ ignores the former.
  • Embed captured Maven output in the returned error, bounded to 8KB, rune-boundary-safe.

Testing

New unit tests, offline via a fake mvnw script (see mvn_test.go). Also verified end-to-end
against a real Artifactory instance with curation-audit — no regressions.

Related: XRAY-157755

Screenshot 2026-08-14 at 4 02 05 PM
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-157755-fix-mvn-dep-ntw-issue branch from d134451 to cc00f1a Compare August 14, 2026 09:56
@gauriy-tech gauriy-tech added the safe to test Approve running integration tests on a pull request label Aug 14, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants