Handle named sections in migrate_config -> rename_section_type#42
Merged
jeverley merged 4 commits intojeverley:mainfrom Apr 1, 2026
Merged
Handle named sections in migrate_config -> rename_section_type#42jeverley merged 4 commits intojeverley:mainfrom
jeverley merged 4 commits intojeverley:mainfrom
Conversation
Owner
|
Thanks @Fail-Safe, I'll test and review this early next week. |
Refactor get_section_ids function so that it returns the id for both named and un-named sections.
Removed the get_section_names function, we can achieve the same outcome with the revised get_section_ids function (keeps things simple).
jeverley
approved these changes
Apr 1, 2026
Owner
jeverley
left a comment
jeverley
left a comment
There was a problem hiding this comment.
Looks good to me now, we can keep things simple by adjusting the syntax used in get_section_ids so that it returns both named and un-named section IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the config migration logic in dscpclassify by properly
handling UCI sections that are named (e.g.,
config <type> <name>) inaddition to the existing support for anonymous/numeric section IDs.
What changed
Adds a helper to enumerate section names for a given UCI section type.
Extends the migration's "rename section type" path to migrate both:
Preserves all options/values and cleans up the old sections.
Why
Some deployments/configs use named UCI sections; without this, those
sections were skipped during type renames in migration, leaving configs
partially migrated.
Testing
Ran migration on configs containing both unnamed and named sections and
verified options/values were carried over and old sections removed cleanly.