Improve logout handling and concurrent login detection#1733
Open
paustint wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Jetstream Desktop IPC auth flow to avoid race conditions where an in-flight auth verification could accidentally restore (or overwrite) authentication state during logout or a concurrent login.
Changes:
- Coalesce concurrent logout calls via a shared
inFlightLogoutpromise and expose “logout-in-flight” state to auth checking. - Harden
checkAuthagainst concurrent logout/login by re-reading persisted app data before mutating it and bailing out when state has changed. - Avoid clearing a valid cached session on transport/network failures during auth verification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paustint
force-pushed
the
bug/fix-desktop-logout-race
branch
from
38d9508 to
a693839
Compare
| // accessToken with latestAppData.deviceId so we never return a mixed-snapshot authInfo. | ||
| return latestAppData.userProfile && latestAppData.deviceId | ||
| ? { | ||
| userProfile: latestAppData.userProfile, |
Comment on lines
+446
to
+448
| return latestAppData.userProfile && latestAppData.deviceId | ||
| ? { | ||
| userProfile: latestAppData.userProfile, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the IPC service to better manage logout processes and detect concurrent logins. This update prevents issues where a logout could inadvertently restore an old authentication state, ensuring a smoother user experience.