fix(shell): quote shellrc source guard so ZDOTDIR with spaces works

[mikeland73]

Summary

The [ -f <path> ] guard that devbox generates around sourcing the user's original shellrc was unquoted in both the zsh and bash branches of shellrc.tmpl. When ZDOTDIR (and therefore the baked-in path) contains a space — e.g. a terminal integration that sets .../Application Support/... — the path split into multiple words, [ failed with too many arguments, the whole if block was skipped, and the user's real shellrc (prompt, aliases, oh-my-zsh, etc.) never got sourced. This quotes the path in both branches and updates the affected golden files.

How was it tested?

devbox run -- go test ./internal/devbox/ passes, including a new regression test TestWriteDevboxShellrcZDOTDIRWithSpaces that builds a shellrc from a ZDOTDIR containing Application Support, asserts the guard is quoted, and runs the generated guard line through /bin/sh to confirm it no longer errors with "too many arguments".

Community Contribution License

All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.

By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes devbox-generated shellrc guards so that sourcing a user’s original shell rc file works even when the rc path contains spaces (notably when ZDOTDIR points into paths like .../Application Support/...). It updates the shellrc template accordingly, refreshes golden test fixtures, and adds a regression test to prevent reintroducing the issue.

Changes:

• Quote .OriginalInitPath in the [ -f ... ] guard in internal/devbox/shellrc.tmpl for both the zsh and non-zsh branches.
• Update shellrc golden files to match the newly quoted guard output.
• Add a regression test to ensure a space-containing ZDOTDIR produces a quoted guard and that the guard line no longer fails with too many arguments.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
internal/devbox/shellrc.tmpl	Quotes the -f guard path to prevent word-splitting when rc paths contain spaces.
internal/devbox/shell_test.go	Adds regression coverage for ZDOTDIR paths containing spaces and validates guard execution via /bin/sh.
internal/devbox/testdata/shellrc/basic/shellrc.golden	Updates expected generated shellrc output with the quoted guard.
internal/devbox/testdata/shellrc/zsh_zdotdir/shellrc.golden	Updates expected generated zsh shellrc output with the quoted guard.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.