Upgrade sqlx dep to 0.9#18
Open
wathiede wants to merge 2 commits into
Open
Conversation
Adapt tracing instrumentation for sqlx 0.9's consuming Execute API and SqlStr changes.
Record the sqlx 0.9 migration, new offline feature, and describe gating fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #17
Changes necessary to deal with sqlx 0.9's consuming
ExecuteAPI andSqlStrtype.Also adds an
offlinefeature following sqlx 0.9 now making this feature optionalNote: I used cursor's AI agent to help with this change. I still reviewed it and fiddled with it until it seemed to be the minimum reasonable change. I don't think it is "slop" but I mention it in case you have strong feelings about AI.
Additionally, when releasing, consider bumping sqlx-tracing to 0.3.0 rather than 0.2.2 to reflect sqlx also went across a major boundary, and this change breaking.