fix(mcp): support npm 10 dependency installation - #210
Merged
Conversation
Deploying specification-website with
|
| Latest commit: |
ef057c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://160cfdf8.specification-website.pages.dev |
| Branch Preview URL: | https://codex-fix-mcp-dependency-ins.specification-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP deployment after #209 failed during
npm ci: npm 10.9.8 did not apply the nested Miniflare/Sharp override consistently with the committed lockfile. Local validation had used npm 11, so it missed the deployment failure.Moves the existing Sharp override to the MCP package level. Sharp is only used by Miniflare in this dependency tree, and the resolved packages and lockfile remain unchanged. Adds a Node 22 MCP CI job for clean installation, auditing, data generation, and type checking so the deployment's installation path runs before merging.
Reproduced the original lockfile error with npm 10.9.8; the corrected package passes a clean install with the same version, reports zero audit vulnerabilities, and passes data generation and type checking.