Fixing issue #766 #806
Open
Fixing issue #766 #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Author
|
@WisdomPill Could you please review this PR when you have time? Thank you. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
========================================
- Coverage 38.2% 38.1% -0.0%
========================================
Files 48 48
Lines 3727 3876 +149
Branches 301 335 +34
========================================
+ Hits 1420 1473 +53
- Misses 2006 2068 +62
- Partials 301 335 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue #766
Added full hash command coverage to the cache client
(hget/hgetall/hmget/hmset via mapping/hsetnx/hincrby/hincrbyfloat/hvals/hstrlen)and exposed them through the cache facade, keeping key/version handling consistent. Tweaked decoding to handle float string responses (needed for hincrbyfloat). Added regression tests for the new hash behaviors (reads, bulk ops, conditional set, numeric increments, value listing, length).