-
-
Notifications
You must be signed in to change notification settings - Fork 303
ORM Bugs #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORM Bugs #757
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 78.28% 78.39% +0.10%
==========================================
Files 26 26
Lines 1543 1569 +26
Branches 244 248 +4
==========================================
+ Hits 1208 1230 +22
- Misses 260 263 +3
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bckohan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @JohananOppongAmoateng
I'd like to keep PRs logically homogenous. Could you please separate out the fix for #505 into a separate PR? It is unrelated to the db routing issues (which I want to accept as is). I'm not sure about supporting 505 yet or not.
676e772 to
0f25153
Compare
@bckohan your requested changes have been done |
This reverts commit f11a455.
bckohan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
This PR addresses multiple issues to improve django-polymorphic's reliability and usability.
Saving polymorphic objects from one database to another caused ForeignKeyViolation because polymorphic_ctype_id referenced ContentType IDs from the source database.
Database routers weren't respected - ContentType was always fetched from default database even when routers specified a different database.
Closes #486
Closes #446