Adding a LARGE_INTEGER.ByValue subclass#1696
Adding a LARGE_INTEGER.ByValue subclass#1696matthiasblaesing merged 1 commit intojava-native-access:masterfrom
Conversation
|
Thanks for the contribution. A few nitpicks:
|
fd2b781 to
98e1578
Compare
Thanks for the review and the detailed feedback! I have addressed all the nitpicks:
Please let me know if there's anything else needed for review! |
CHANGES.md
Outdated
|
|
||
| Features | ||
| -------- | ||
|
|
||
| * [#1696](https://github.com/java-native-access/jna/pull/1696): Add `LARGE_INTEGER.ByValue` to `LARGE_INTEGER` in `WinNT.java` - [@Baier](https://github.com/baier233). No newline at end of file |
There was a problem hiding this comment.
Please move this into the "Features" section at the top of the file. The entries are sorted anti chronological (newest first). There is always a section for the next release (5.19.0). The part inside the square brackets should be the github username.
6e39200 to
fb9a5f1
Compare
|
Checkstyle is not happy:
|
Oops,everything should be fine now. |
|
Looks sane. Thank you. |
See issue #1695